Skip to content

Update Spheral to use spack v1.1.0#421

Open
mcfadden8 wants to merge 102 commits intodevelopfrom
task/spack1.0.2
Open

Update Spheral to use spack v1.1.0#421
mcfadden8 wants to merge 102 commits intodevelopfrom
task/spack1.0.2

Conversation

@mcfadden8
Copy link
Collaborator

@mcfadden8 mcfadden8 commented Oct 27, 2025

Summary

  • This PR is a refactor of the build scripts to use spack v1.1
  • It does the following:
    • Move packages to align with new location associated with spack v1.1
    • Updates Dockerfile for github CI to use Ubuntu 24.04, gcc 13, and python 3.12
    • Adds python 3.12 support to ATS tests

ToDo :

  • Annotate RELEASE_NOTES.md with notable changes.
  • Create LLNLSpheral PR pointing at this branch. (182)
  • LLNLSpheral PR has passed all tests.

Replace obsolete "spack concretize -U" with
spack:concretizer:reuse:false to disable it by default within our
build environment.

Move compiler definitions from compilers.yaml to packages.yaml since
compilers.yaml is obsolete in v1.0

Update specs to handle new semantics for "%" in v1.0

Updated using packages to point to new, separate package repository
for spack.

Added "depends_on" for package language dependencies (c, cxx,
fortran)

Renamed "m-aneos" package to "m_aneos" to match new package naming
requirements of spack v1.0
@mcfadden8

This comment was marked as outdated.

…, added c and cxx dependencies for packages missing them, added fortran dependency to spheral to avoid known spack bug, python concretize function is called instead of SpackCommand
@mcfadden8 mcfadden8 marked this pull request as draft October 29, 2025 14:16
Copy link
Member

@becker33 becker33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commeting everything I noticed while looking for the issue we were discussing on slack for setting the working dir.

Spack has been decoupled from the packages it manages in v1
allowing for more than just spack to be installed as part of
a "spack instance".  The tpl-manager.py now allows for the
user to specify a directory where the spack instance, the
package instance, as well as some other miscellaneous items.
@mcfadden8 mcfadden8 marked this pull request as ready for review February 19, 2026 21:38
steps:
- name: Checkout repository
uses: actions/checkout@v3
uses: actions/checkout@v4
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In case anyone is curious about this change, I had some problems when/if PolyClipper was being checked out. Updating to v4 and including the tokens for recursive checkout fixed it.

'extern/PolyClipper'...
...
'extern/PYB11Generator/extern/pybind11'
  Cloning into '/home/runner/work/spheral/spheral/extern/PYB11Generator/extern/pybind11'...
  Error: fatal: could not read Username for 'https://github.com': terminal prompts disabled

@ldowen
Copy link
Collaborator

ldowen commented Feb 19, 2026

Need to update the RELEASE_NOTES.md.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants