[lldb] [cosmetic] Update help message of (lldb) b#149114
Conversation
|
@llvm/pr-subscribers-lldb Author: None (royitaqi) Changes
However, the help message doesn't mention the first use case. This patch adds help message to mention it by adding "List all breakpoints, or ...". Without patch: With patch: Full diff: https://github.com/llvm/llvm-project/pull/149114.diff 1 Files Affected:
diff --git a/lldb/source/Interpreter/CommandInterpreter.cpp b/lldb/source/Interpreter/CommandInterpreter.cpp
index 00c3472444d2e..2d8ab7bf3bbf4 100644
--- a/lldb/source/Interpreter/CommandInterpreter.cpp
+++ b/lldb/source/Interpreter/CommandInterpreter.cpp
@@ -616,7 +616,8 @@ void CommandInterpreter::LoadCommandDictionary() {
std::unique_ptr<CommandObjectRegexCommand> break_regex_cmd_up(
new CommandObjectRegexCommand(
*this, "_regexp-break",
- "Set a breakpoint using one of several shorthand formats.",
+ "List all breakpoints, or set a breakpoint using one of several "
+ "shorthand formats.",
"\n"
"_regexp-break <filename>:<linenum>:<colnum>\n"
" main.c:12:21 // Break at line 12 and column "
|
(lldb) b(lldb) b
dmpots
left a comment
There was a problem hiding this comment.
LGTM with one suggestion.
|
[begin bikeshedding]
My reasoning is that it describes the more common use case first while also telling you how to get the behavior for listing breakpoints. [end bikeshedding] |
|
Folks, how about now? (see PR description for latest visualization) -- FWIW, @JDevlieghere: That wasn't bikeshedding at all. The order is important because it decides what gets delivered to the user/reader. Thanks for the great suggestion. |
(lldb) bcan be used in two different ways:bwithout arguments, it lists all existing breakpoints.bwith arguments, it adds breakpoints.However, the help message doesn't mention the first use case. This patch adds help message to mention it.
Without patch:
With patch: