[Sema] Use llvm::all_of (NFC)#149256
Merged
kazutakahirata merged 1 commit intollvm:mainfrom Jul 17, 2025
Merged
Conversation
We can pass a range to llvm::all_of.
Member
|
@llvm/pr-subscribers-clang Author: Kazu Hirata (kazutakahirata) ChangesWe can pass a range to llvm::all_of. Full diff: https://github.com/llvm/llvm-project/pull/149256.diff 1 Files Affected:
diff --git a/clang/lib/Sema/AnalysisBasedWarnings.cpp b/clang/lib/Sema/AnalysisBasedWarnings.cpp
index 5eba024e83634..d1400cbfc884d 100644
--- a/clang/lib/Sema/AnalysisBasedWarnings.cpp
+++ b/clang/lib/Sema/AnalysisBasedWarnings.cpp
@@ -522,8 +522,7 @@ static bool areAllValuesNoReturn(const VarDecl *VD, const CFGBlock &VarBlk,
}
// If all checked blocks satisfy the condition, the check is finished.
- if (std::all_of(BlocksToCheck.begin(), BlocksToCheck.end(),
- BlockSatisfiesCondition))
+ if (llvm::all_of(BlocksToCheck, BlockSatisfiesCondition))
return true;
// If this block does not contain the variable definition, check
|
arsenm
approved these changes
Jul 17, 2025
This was referenced Jul 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We can pass a range to llvm::all_of.