[libc++][Android] Reenable 2 tests for Android#149415
Merged
Conversation
Now that the Android clang has been upgraded to clang-r563880 (llvm.org/pr148998), these two tests pass again.
llvmbot
added
the
libc++
Member
|
@llvm/pr-subscribers-libcxx Author: Ryan Prichard (rprichard) ChangesNow that the Android clang has been upgraded to clang-r563880 (llvm.org/pr148998), these two tests pass again. Full diff: https://github.com/llvm/llvm-project/pull/149415.diff 2 Files Affected:
diff --git a/libcxx/test/std/utilities/meta/meta.unary/meta.unary.comp/is_bounded_array.pass.cpp b/libcxx/test/std/utilities/meta/meta.unary/meta.unary.comp/is_bounded_array.pass.cpp
index 97e3afed1c036..8e57e8913dcbe 100644
--- a/libcxx/test/std/utilities/meta/meta.unary/meta.unary.comp/is_bounded_array.pass.cpp
+++ b/libcxx/test/std/utilities/meta/meta.unary/meta.unary.comp/is_bounded_array.pass.cpp
@@ -7,9 +7,6 @@
//===----------------------------------------------------------------------===//
// UNSUPPORTED: c++03, c++11, c++14, c++17
-// The Clang version that Android currently uses in the CI is too old.
-// UNSUPPORTED: LIBCXX-ANDROID-FIXME
-
// type_traits
// is_bounded_array<T>
diff --git a/libcxx/test/std/utilities/meta/meta.unary/meta.unary.prop/has_unique_object_representations.compile.pass.cpp b/libcxx/test/std/utilities/meta/meta.unary/meta.unary.prop/has_unique_object_representations.compile.pass.cpp
index ac63fec691377..bd7da40daf2bc 100644
--- a/libcxx/test/std/utilities/meta/meta.unary/meta.unary.prop/has_unique_object_representations.compile.pass.cpp
+++ b/libcxx/test/std/utilities/meta/meta.unary/meta.unary.prop/has_unique_object_representations.compile.pass.cpp
@@ -8,9 +8,6 @@
// UNSUPPORTED: c++03, c++11, c++14
-// The Clang version that Android currently uses in the CI is too old.
-// UNSUPPORTED: LIBCXX-ANDROID-FIXME
-
// type_traits
// has_unique_object_representations
|
philnik777
approved these changes
Jul 17, 2025
Member
|
/cherry-pick 8aa4fc0 |
Member
|
Failed to cherry-pick: 8aa4fc0 https://github.com/llvm/llvm-project/actions/runs/16422246220 Please manually backport the fix and push it to your github fork. Once this is done, please create a pull request |
tru
pushed a commit
to frederick-vs-ja/llvm-project
that referenced
this pull request
Jul 24, 2025
Now that the Android clang has been upgraded to clang-r563880 (llvm.org/pr148998), these two tests pass again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that the Android clang has been upgraded to clang-r563880 (llvm.org/pr148998), these two tests pass again.