[DAG] visitFREEZE - remove unused HadMaybePoisonOperands check. NFC.

[RKSimon]

Redundant since #145939

[llvmbot]

@llvm/pr-subscribers-llvm-selectiondag

Author: Simon Pilgrim (RKSimon)

Changes

Redundant since #145939

---

Full diff: https://github.com/llvm/llvm-project/pull/149517.diff

1 Files Affected:

• (modified) llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp (+1-5)

diff --git a/llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp b/llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp
index 40464e91f9efc..867c7934a8a71 100644
--- a/llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp
+++ b/llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp
@@ -16772,12 +16772,8 @@ SDValue DAGCombiner::visitFREEZE(SDNode *N) {
     if (DAG.isGuaranteedNotToBeUndefOrPoison(Op, /*PoisonOnly*/ false,
                                              /*Depth*/ 1))
       continue;
-    bool HadMaybePoisonOperands = !MaybePoisonOperands.empty();
-    bool IsNewMaybePoisonOperand = MaybePoisonOperands.insert(Op).second;
-    if (IsNewMaybePoisonOperand)
+    if (MaybePoisonOperands.insert(Op).second)
       MaybePoisonOperandNumbers.push_back(OpNo);
-    if (!HadMaybePoisonOperands)
-      continue;
   }
   // NOTE: the whole op may be not guaranteed to not be undef or poison because
   // it could create undef or poison due to it's poison-generating flags.

[llvm-ci]

LLVM Buildbot has detected a new failure on builder lldb-arm-ubuntu running on linaro-lldb-arm-ubuntu while building llvm at step 6 "test".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/18/builds/19211

Here is the relevant piece of the build log for the reference

Step 6 (test) failure: build (failure)
...
PASS: lldb-unit :: Protocol/./ProtocolTests/18/26 (2734 of 3341)
PASS: lldb-unit :: Protocol/./ProtocolTests/2/26 (2735 of 3341)
PASS: lldb-unit :: Protocol/./ProtocolTests/19/26 (2736 of 3341)
PASS: lldb-unit :: Protocol/./ProtocolTests/21/26 (2737 of 3341)
PASS: lldb-unit :: Protocol/./ProtocolTests/22/26 (2738 of 3341)
PASS: lldb-unit :: Protocol/./ProtocolTests/23/26 (2739 of 3341)
PASS: lldb-unit :: Protocol/./ProtocolTests/25/26 (2740 of 3341)
PASS: lldb-unit :: Protocol/./ProtocolTests/3/26 (2741 of 3341)
PASS: lldb-unit :: Protocol/./ProtocolTests/24/26 (2742 of 3341)
PASS: lldb-unit :: Protocol/./ProtocolTests/4/26 (2743 of 3341)
FAIL: lldb-unit :: Protocol/./ProtocolTests/20/26 (2744 of 3341)
******************** TEST 'lldb-unit :: Protocol/./ProtocolTests/20/26' FAILED ********************
Script(shard):
--
GTEST_OUTPUT=json:/home/tcwg-buildbot/worker/lldb-arm-ubuntu/build/tools/lldb/unittests/Protocol/./ProtocolTests-lldb-unit-3743919-20-26.json GTEST_SHUFFLE=0 GTEST_TOTAL_SHARDS=26 GTEST_SHARD_INDEX=20 /home/tcwg-buildbot/worker/lldb-arm-ubuntu/build/tools/lldb/unittests/Protocol/./ProtocolTests
--

Script:
--
/home/tcwg-buildbot/worker/lldb-arm-ubuntu/build/tools/lldb/unittests/Protocol/./ProtocolTests --gtest_filter=ProtocolServerMCPTest.ToolsList
--
../llvm-project/lldb/unittests/Protocol/ProtocolMCPServerTest.cpp:211: Failure
Value of: llvm::detail::TakeExpected(response_str)
Expected: succeeded
  Actual: failed  (transport operation timed out)


../llvm-project/lldb/unittests/Protocol/ProtocolMCPServerTest.cpp:211
Value of: llvm::detail::TakeExpected(response_str)
Expected: succeeded
  Actual: failed  (transport operation timed out)



********************
PASS: lldb-unit :: Protocol/./ProtocolTests/7/26 (2745 of 3341)
PASS: lldb-unit :: Protocol/./ProtocolTests/6/26 (2746 of 3341)
PASS: lldb-unit :: Protocol/./ProtocolTests/8/26 (2747 of 3341)
PASS: lldb-unit :: Protocol/./ProtocolTests/9/26 (2748 of 3341)
PASS: lldb-unit :: Protocol/./ProtocolTests/5/26 (2749 of 3341)
PASS: lldb-unit :: ScriptInterpreter/Python/./ScriptInterpreterPythonTests/0/39 (2750 of 3341)
PASS: lldb-unit :: ScriptInterpreter/Python/./ScriptInterpreterPythonTests/1/39 (2751 of 3341)
PASS: lldb-unit :: ScriptInterpreter/Python/./ScriptInterpreterPythonTests/11/39 (2752 of 3341)
PASS: lldb-unit :: ScriptInterpreter/Python/./ScriptInterpreterPythonTests/12/39 (2753 of 3341)
PASS: lldb-unit :: ScriptInterpreter/Python/./ScriptInterpreterPythonTests/10/39 (2754 of 3341)
PASS: lldb-unit :: ScriptInterpreter/Python/./ScriptInterpreterPythonTests/13/39 (2755 of 3341)
PASS: lldb-unit :: ScriptInterpreter/Python/./ScriptInterpreterPythonTests/14/39 (2756 of 3341)
PASS: lldb-unit :: ScriptInterpreter/Python/./ScriptInterpreterPythonTests/16/39 (2757 of 3341)
PASS: lldb-unit :: ScriptInterpreter/Python/./ScriptInterpreterPythonTests/15/39 (2758 of 3341)