[libc] Revise document on building exhaustive math functions.#149635
Merged
[libc] Revise document on building exhaustive math functions.#149635
Conversation
Member
|
@llvm/pr-subscribers-libc Author: Connector Switch (c8ef) ChangesI suspect the reason is that we use Full diff: https://github.com/llvm/llvm-project/pull/149635.diff 1 Files Affected:
diff --git a/libc/src/math/docs/add_math_function.md b/libc/src/math/docs/add_math_function.md
index daaf1a3ec5639..d2c85ecf7d9b7 100644
--- a/libc/src/math/docs/add_math_function.md
+++ b/libc/src/math/docs/add_math_function.md
@@ -183,8 +183,8 @@ implementation (which is very often glibc).
- Build and Run exhaustive test (might take hours to run):
```
- $ ninja libc.test.src.math.exhaustive.<func>_test
- $ projects/libc/test/src/math/exhaustive/libc.test.src.math.exhaustive.<func>_test
+ $ ninja libc.test.src.math.exhaustive.<func>_test.__unit__
+ $ projects/libc/test/src/math/exhaustive/libc.test.src.math.exhaustive.<func>_test.__unit__
```
- Build and Run performance test:
|
lntue
approved these changes
Jul 20, 2025
Contributor
Author
Merge activity
|
This was referenced Jul 23, 2025
mahesh-attarde
pushed a commit
to mahesh-attarde/llvm-project
that referenced
this pull request
Jul 28, 2025
…49635) I suspect the reason is that we use `add_fp_unittest` in exhaustive testing, so the suffix `__unit__` is necessary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I suspect the reason is that we use
add_fp_unittestin exhaustive testing, so the suffix__unit__is necessary.