Conversation
Member
|
@llvm/pr-subscribers-libc Author: None (lntue) ChangesFix offload build bots: https://lab.llvm.org/buildbot/#/builders/10/builds/10213 Full diff: https://github.com/llvm/llvm-project/pull/150726.diff 1 Files Affected:
diff --git a/libc/src/__support/math/asin.h b/libc/src/__support/math/asin.h
index 9734f349688c0..84fc1cfd5679e 100644
--- a/libc/src/__support/math/asin.h
+++ b/libc/src/__support/math/asin.h
@@ -27,8 +27,6 @@ namespace math {
static constexpr double asin(double x) {
using namespace asin_internal;
- using Float128 = fputil::DyadicFloat<128>;
- using DoubleDouble = fputil::DoubleDouble;
using FPBits = fputil::FPBits<double>;
FPBits xbits(x);
@@ -76,6 +74,9 @@ static constexpr double asin(double x) {
#ifdef LIBC_MATH_HAS_SKIP_ACCURATE_PASS
return x * asin_eval(x * x);
#else
+ using Float128 = fputil::DyadicFloat<128>;
+ using DoubleDouble = fputil::DoubleDouble;
+
unsigned idx = 0;
DoubleDouble x_sq = fputil::exact_mult(x, x);
double err = xbits.abs().get_val() * 0x1.0p-51;
|
Kewen12
approved these changes
Jul 26, 2025
Contributor
|
Thanks for the fix! Our bot is happy. |
mahesh-attarde
pushed a commit
to mahesh-attarde/llvm-project
that referenced
this pull request
Jul 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix offload build bots: https://lab.llvm.org/buildbot/#/builders/10/builds/10213