Skip to content

[lldb][tests/FreeBSDKernel] Skip tests on non-FreeBSD hosts#182363

Merged
mchoo7 merged 1 commit intollvm:mainfrom
mchoo7:fvc
Feb 19, 2026
Merged

[lldb][tests/FreeBSDKernel] Skip tests on non-FreeBSD hosts#182363
mchoo7 merged 1 commit intollvm:mainfrom
mchoo7:fvc

Conversation

@mchoo7
Copy link
Copy Markdown
Contributor

@mchoo7 mchoo7 commented Feb 19, 2026

#181283 removed fvc but it still remains in tests. This causes testing on non-FreeBSD hosts. Thus add skipUnlessPlatform decorator.

@mchoo7 mchoo7 requested a review from JDevlieghere as a code owner February 19, 2026 20:21
@llvmbot llvmbot added the lldb label Feb 19, 2026
@llvmbot
Copy link
Copy Markdown
Member

llvmbot commented Feb 19, 2026

@llvm/pr-subscribers-lldb

Author: Minsoo Choo (mchoo7)

Changes

#181283 removed fvc but it still remains in tests. This causes testing on non-FreeBSD hosts. Thus add skipUnlessPlatform decorator.


Full diff: https://github.com/llvm/llvm-project/pull/182363.diff

1 Files Affected:

  • (modified) lldb/test/API/functionalities/postmortem/FreeBSDKernel/TestFreeBSDKernelVMCore.py (+3-3)
diff --git a/lldb/test/API/functionalities/postmortem/FreeBSDKernel/TestFreeBSDKernelVMCore.py b/lldb/test/API/functionalities/postmortem/FreeBSDKernel/TestFreeBSDKernelVMCore.py
index 86ba661296a7f..ed238f8da83e3 100644
--- a/lldb/test/API/functionalities/postmortem/FreeBSDKernel/TestFreeBSDKernelVMCore.py
+++ b/lldb/test/API/functionalities/postmortem/FreeBSDKernel/TestFreeBSDKernelVMCore.py
@@ -2,13 +2,13 @@
 import shutil
 import struct
 
-import lldb
+from lldbsuite.test import lldbutil
 from lldbsuite.test.decorators import *
 from lldbsuite.test.lldbtest import *
-from lldbsuite.test import lldbutil
 
+import lldb
 
-@skipIfFBSDVMCoreSupportMissing
+@skipUnlessPlatform(["freebsd"])
 class FreeBSDKernelVMCoreTestCase(TestBase):
     NO_DEBUG_INFO_TESTCASE = True
     maxDiff = None

@mchoo7 mchoo7 force-pushed the fvc branch 3 times, most recently from 0a930ff to 75335e7 Compare February 19, 2026 20:23
Signed-off-by: Minsoo Choo <minsoochoo0122@proton.me>
@mchoo7
Copy link
Copy Markdown
Contributor Author

mchoo7 commented Feb 19, 2026

ping @bulbazord

@mchoo7
Copy link
Copy Markdown
Contributor Author

mchoo7 commented Feb 19, 2026

This seems straightforward. I'll revert this later if there is any issue. For now let's focus on CI errors.

@mchoo7 mchoo7 merged commit 3d71201 into llvm:main Feb 19, 2026
10 checks passed
@mchoo7 mchoo7 deleted the fvc branch February 19, 2026 21:03
@bulbazord
Copy link
Copy Markdown
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants