[lldb][tests/FreeBSDKernel] Skip tests on non-FreeBSD hosts#182363
Merged
[lldb][tests/FreeBSDKernel] Skip tests on non-FreeBSD hosts#182363
Conversation
Member
|
@llvm/pr-subscribers-lldb Author: Minsoo Choo (mchoo7) Changes#181283 removed fvc but it still remains in tests. This causes testing on non-FreeBSD hosts. Thus add Full diff: https://github.com/llvm/llvm-project/pull/182363.diff 1 Files Affected:
diff --git a/lldb/test/API/functionalities/postmortem/FreeBSDKernel/TestFreeBSDKernelVMCore.py b/lldb/test/API/functionalities/postmortem/FreeBSDKernel/TestFreeBSDKernelVMCore.py
index 86ba661296a7f..ed238f8da83e3 100644
--- a/lldb/test/API/functionalities/postmortem/FreeBSDKernel/TestFreeBSDKernelVMCore.py
+++ b/lldb/test/API/functionalities/postmortem/FreeBSDKernel/TestFreeBSDKernelVMCore.py
@@ -2,13 +2,13 @@
import shutil
import struct
-import lldb
+from lldbsuite.test import lldbutil
from lldbsuite.test.decorators import *
from lldbsuite.test.lldbtest import *
-from lldbsuite.test import lldbutil
+import lldb
-@skipIfFBSDVMCoreSupportMissing
+@skipUnlessPlatform(["freebsd"])
class FreeBSDKernelVMCoreTestCase(TestBase):
NO_DEBUG_INFO_TESTCASE = True
maxDiff = None
|
0a930ff to
75335e7
Compare
Signed-off-by: Minsoo Choo <minsoochoo0122@proton.me>
Contributor
Author
|
ping @bulbazord |
Contributor
Author
|
This seems straightforward. I'll revert this later if there is any issue. For now let's focus on CI errors. |
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#181283 removed fvc but it still remains in tests. This causes testing on non-FreeBSD hosts. Thus add
skipUnlessPlatformdecorator.