[lldb][FreeBSDKernelCore] Do not include <cstddef>#186193
Merged
Conversation
Signed-off-by: Minsoo Choo <minsoochoo0122@proton.me>
Member
|
@llvm/pr-subscribers-backend-risc-v @llvm/pr-subscribers-lldb Author: Minsoo Choo (mchoo7) Changes
Fixes 3f65a03 (#183969) Full diff: https://github.com/llvm/llvm-project/pull/186193.diff 6 Files Affected:
diff --git a/lldb/source/Plugins/Process/FreeBSD-Kernel-Core/RegisterContextFreeBSDKernelCore_arm.cpp b/lldb/source/Plugins/Process/FreeBSD-Kernel-Core/RegisterContextFreeBSDKernelCore_arm.cpp
index 8a2d7abfb277f..1477cf75e9f6f 100644
--- a/lldb/source/Plugins/Process/FreeBSD-Kernel-Core/RegisterContextFreeBSDKernelCore_arm.cpp
+++ b/lldb/source/Plugins/Process/FreeBSD-Kernel-Core/RegisterContextFreeBSDKernelCore_arm.cpp
@@ -15,7 +15,6 @@
#include "llvm/Support/Endian.h"
#if defined(__FreeBSD__) && defined(__arm__)
-#include <cstddef>
#include <machine/frame.h>
#endif
diff --git a/lldb/source/Plugins/Process/FreeBSD-Kernel-Core/RegisterContextFreeBSDKernelCore_arm64.cpp b/lldb/source/Plugins/Process/FreeBSD-Kernel-Core/RegisterContextFreeBSDKernelCore_arm64.cpp
index c4b3e2b0c25fc..80a5e0cf13a7c 100644
--- a/lldb/source/Plugins/Process/FreeBSD-Kernel-Core/RegisterContextFreeBSDKernelCore_arm64.cpp
+++ b/lldb/source/Plugins/Process/FreeBSD-Kernel-Core/RegisterContextFreeBSDKernelCore_arm64.cpp
@@ -19,7 +19,6 @@
#include "llvm/Support/Endian.h"
#if defined(__FreeBSD__) && defined(__aarch64__)
-#include <cstddef>
#include <machine/pcb.h>
#include <sys/param.h>
#endif
diff --git a/lldb/source/Plugins/Process/FreeBSD-Kernel-Core/RegisterContextFreeBSDKernelCore_i386.cpp b/lldb/source/Plugins/Process/FreeBSD-Kernel-Core/RegisterContextFreeBSDKernelCore_i386.cpp
index c88f7f601b12a..0b44e52764d7c 100644
--- a/lldb/source/Plugins/Process/FreeBSD-Kernel-Core/RegisterContextFreeBSDKernelCore_i386.cpp
+++ b/lldb/source/Plugins/Process/FreeBSD-Kernel-Core/RegisterContextFreeBSDKernelCore_i386.cpp
@@ -14,7 +14,6 @@
#include "llvm/Support/Endian.h"
#if defined(__FreeBSD__) && defined(__i386__)
-#include <cstddef>
#include <machine/pcb.h>
#endif
diff --git a/lldb/source/Plugins/Process/FreeBSD-Kernel-Core/RegisterContextFreeBSDKernelCore_ppc64le.cpp b/lldb/source/Plugins/Process/FreeBSD-Kernel-Core/RegisterContextFreeBSDKernelCore_ppc64le.cpp
index b8e5578b1b51e..3b0f269a3014d 100644
--- a/lldb/source/Plugins/Process/FreeBSD-Kernel-Core/RegisterContextFreeBSDKernelCore_ppc64le.cpp
+++ b/lldb/source/Plugins/Process/FreeBSD-Kernel-Core/RegisterContextFreeBSDKernelCore_ppc64le.cpp
@@ -14,7 +14,6 @@
#include "llvm/Support/Endian.h"
#if defined(__FreeBSD__) && defined(__powerpc64__) && defined(__LITTLE_ENDIAN__)
-#include <cstddef>
#include <machine/pcb.h>
#endif
diff --git a/lldb/source/Plugins/Process/FreeBSD-Kernel-Core/RegisterContextFreeBSDKernelCore_riscv64.cpp b/lldb/source/Plugins/Process/FreeBSD-Kernel-Core/RegisterContextFreeBSDKernelCore_riscv64.cpp
index ea632968f9ebc..52a2f91742c76 100644
--- a/lldb/source/Plugins/Process/FreeBSD-Kernel-Core/RegisterContextFreeBSDKernelCore_riscv64.cpp
+++ b/lldb/source/Plugins/Process/FreeBSD-Kernel-Core/RegisterContextFreeBSDKernelCore_riscv64.cpp
@@ -14,7 +14,6 @@
#include "llvm/Support/Endian.h"
#if defined(__FreeBSD__) && defined(__riscv) && __riscv_xlen == 64
-#include <cstddef>
#include <machine/pcb.h>
#endif
diff --git a/lldb/source/Plugins/Process/FreeBSD-Kernel-Core/RegisterContextFreeBSDKernelCore_x86_64.cpp b/lldb/source/Plugins/Process/FreeBSD-Kernel-Core/RegisterContextFreeBSDKernelCore_x86_64.cpp
index 0034408b8f9ba..8f833aa47e486 100644
--- a/lldb/source/Plugins/Process/FreeBSD-Kernel-Core/RegisterContextFreeBSDKernelCore_x86_64.cpp
+++ b/lldb/source/Plugins/Process/FreeBSD-Kernel-Core/RegisterContextFreeBSDKernelCore_x86_64.cpp
@@ -14,7 +14,6 @@
#include "llvm/Support/Endian.h"
#if defined(__FreeBSD__) && defined(__amd64__)
-#include <cstddef>
#include <machine/pcb.h>
#endif
|
DavidSpickett
approved these changes
Mar 12, 2026
Collaborator
DavidSpickett
left a comment
DavidSpickett
left a comment
There was a problem hiding this comment.
If it builds for you then it's fine with me, thanks for the quick follow up.
Collaborator
|
Just because you can doesn’t mean you should. IWYU would say this header should still be included rather than implicitly relying on some other header already including it, no? |
Contributor
Author
KGDB doesn't explicitly include |
Collaborator
|
I might be missing other advice that recommends IWYU, but this does not require it at least: I don't mind either way. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
<cstddef>was included for static assertion usingoffsetof(), but it turns out that the header is already included before. Thus remove<cstddef>includes fromRegisterContextFreeBSDKernelCore_<arch>.cppfiles.Fixes 3f65a03 (#183969)