fix: add missing return after no-worker error in controller stream generator#3790
Open
alvinttang wants to merge 1 commit intolm-sys:mainfrom
Open
fix: add missing return after no-worker error in controller stream generator#3790alvinttang wants to merge 1 commit intolm-sys:mainfrom
alvinttang wants to merge 1 commit intolm-sys:mainfrom
Conversation
In Controller.worker_api_generate_stream(), when no worker is available
for the requested model, the code yields an error response but does not
return. This causes it to fall through and attempt a POST request to an
empty worker address ("" + "/worker_generate_stream"), which raises a
MissingSchema or ConnectionError exception. The exception is then caught
and a misleading "worker timeout" error is yielded as a second response.
Adding a return statement after the no-worker yield ensures the generator
terminates cleanly with the correct error message.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Controller.worker_api_generate_stream(), when no worker is available for the requested model, the code yields an error response but does not return from the generator. This causes execution to fall through into thetryblock, which attempts a POST request to an empty URL ("" + "/worker_generate_stream"), raising aMissingSchema/ConnectionError. That exception is caught and a second, misleading "worker timeout" error is yielded to the client.returnafter the no-worker yield ensures the generator terminates cleanly with only the correct error message.How to reproduce
/worker_generate_streamrequest to the controllerTest plan
yieldin a generator does not exit the function, soreturnis requiredhandle_no_workerare affected🤖 Generated with Claude Code