Merged
Conversation
AlexanderFengler
approved these changes
Jul 12, 2024
Member
AlexanderFengler
left a comment
AlexanderFengler
left a comment
There was a problem hiding this comment.
This is good, just see one comment.
| assert "strange" in caplog.records[0].message | ||
|
|
||
|
|
||
| def test_resampling(data_ddm): |
Member
There was a problem hiding this comment.
we should put a not somewhere concerning the resulting behavior.
If I understand correctly, if you change sample_2 you automatically change model.traces?
Collaborator
Author
There was a problem hiding this comment.
I updated the return section of the sample() method and traces object to indicate that .sample() returns a reference to model.traces object, which stores the traces of the last call to .sample().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #481. Please see the issue for details. We have written tests to ensure the behavior described in #481