Added UserParam class for user parameter specification#579
Closed
digicosmos86 wants to merge 7 commits into
Closed
Added UserParam class for user parameter specification#579digicosmos86 wants to merge 7 commits into
digicosmos86 wants to merge 7 commits into
Conversation
Closed
AlexanderFengler
approved these changes
Aug 30, 2024
cpaniaguam
requested changes
Sep 9, 2024
Collaborator
cpaniaguam
left a comment
cpaniaguam
left a comment
There was a problem hiding this comment.
Looks good. I pointed out a couple of things I would change but might not be needed perhaps due to conventions that I'm not aware of yet.
| self.args: dict = {} | ||
|
|
||
| def to_dict(self) -> dict[str, Any]: | ||
| """Convert the object to JSON. |
Collaborator
There was a problem hiding this comment.
The type of the return object is a dict (also suggested by the function's name). Should the docstring be in line with this?
Suggested change
| """Convert the object to JSON. | |
| """Convert the object to a dictionary. |
| return result | ||
|
|
||
| @staticmethod | ||
| def from_dict(d: dict) -> "Prior": |
Collaborator
There was a problem hiding this comment.
Suggested change
| def from_dict(d: dict) -> "Prior": | |
| def from_dict(d: dict) -> Prior: |
| @staticmethod | ||
| def from_bambi( | ||
| bambi_prior: bmb.Prior, bounds: tuple[float, float] | None = None | ||
| ) -> "Prior": |
Collaborator
There was a problem hiding this comment.
Suggested change
| ) -> "Prior": | |
| ) -> Prior: |
Collaborator
There was a problem hiding this comment.
Why not use the truthy/falsy nature of the values in many of these checks? Makes for more consice code.
Member
|
@digicosmos86 is this on hold or pushed through #590 at this point? |
Member
|
From what I can see this is redundant now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: To avoid conflict with
src/jhssm/param.py, I am naming the directorysrc/hssm/param_refactorfor now. Once all integration is tested, I will rename this directoryWhat was done in this PR:
prior.pyto prepare for model outputhssm.Param) for users to specify priors and store user specification