fix: suppress buggy output from pytensor.function#595
Merged
cpaniaguam merged 3 commits intomainfrom Oct 23, 2024
Merged
Conversation
Member
AlexanderFengler
left a comment
AlexanderFengler
left a comment
There was a problem hiding this comment.
Is this functionality meant to sit in test_likelihoods.py or is this wip?
Collaborator
Author
|
HSSM/src/hssm/distribution_utils/dist.py Line 413 in fa12018 It could be used there as well right now. @AlexanderFengler Where would a good home be for the output suppressor? |
cpaniaguam
force-pushed
the
fix-suppress-output-pytensor-function
branch
from
5793a2e to
7e4a5a2
Compare
digicosmos86
approved these changes
Oct 22, 2024
Collaborator
digicosmos86
left a comment
digicosmos86
left a comment
There was a problem hiding this comment.
Looks good to me! Just one comment: we use numpy docstring format. The docstring is slightly non-standard :)
AlexanderFengler
approved these changes
Oct 23, 2024
| return [tmp.astype(int) for tmp in np.array_split(data, num_splits)] | ||
|
|
||
|
|
||
| class SuppressOutput: |
Member
There was a problem hiding this comment.
sorry about the late response here, but his converged to the right spot :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #594.