Merged
Conversation
digicosmos86
reviewed
Feb 6, 2025
Collaborator
digicosmos86
left a comment
There was a problem hiding this comment.
This looks great! I really like how clean it is, and it is exactly what we were thinking of.
Taking this further, we can now move on to thinking about how not to modify the default_model_config object (it is really supposed to be read-only) and also lazy-loading only certain model configs as needed, but this is already pretty great!
Codecov ReportAttention: Patch coverage is
|
…l registration logic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces model registration functionality.
Model Registration:
register.pyfor registering custom models in HSSM, including functionsregister_model,list_registered_models, andget_model_info.src/hssm/__init__.pyto include theregister_modelfunction. [1] [2]Other updates
Dependency Updates:
ipython,nbconvert, andptpythonto thedevdependencies inpyproject.toml. [1] [2]Initialization Refactoring:
__init__method insrc/hssm/hssm.pyto use a dictionary comprehension for initializingself._init_args.