672 create a supported models class property for hssm#673
Merged
cpaniaguam merged 3 commits intomainfrom Feb 28, 2025
Merged
Conversation
2 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
|
AlexanderFengler
approved these changes
Feb 28, 2025
Member
AlexanderFengler
left a comment
There was a problem hiding this comment.
looks good! Thanks @cpaniaguam
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes several updates to the
docs/tutorials/main_tutorial.ipynbandsrc/hssm/hssm.pyfiles. The changes primarily focus on improving documentation and adding new functionalities to the HSSM class.Codebase enhancements:
classpropertydecorator to theHSSMclass insrc/hssm/hssm.pyto allow class-level properties that perform computations or access class-level data. This decorator ensures compatibility across Python versions 3.10 through 3.12.supported_modelsclass property in theHSSMclass to return a tuple of all supported model names.Documentation updates:
docs/tutorials/main_tutorial.ipynbto reflect the new structure, changinghssm.defaults.SupportedModelstohssm.HSSM.supported_modelsand updating the method to check detailed model information. [1] [2] [3] [4] [5]