Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes test failures caused by updated NumPy string representations and suppresses upcoming DeprecationWarnings by converting NumPy arrays to Python lists.
- Updated regex patterns in unit tests to use raw strings, escaping backslashes correctly
- Converted NumPy array slices to lists in
data_validator.pyto avoid deprecated behaviors
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/param/test_user_param.py | Switched regex matches to raw strings for backslash-safe patterns |
| tests/param/test_param.py | Same raw-string update for regex in bounds validation tests |
| src/hssm/data_validator.py | Changed array slicing results to list conversions (.tolist) |
Comments suppressed due to low confidence (1)
src/hssm/data_validator.py:100
- NumPy arrays use
.tolist()instead of.to_list(). Please change.to_list()to.tolist()for correct list conversion.
np.setdiff1d(self.choices, unique_responses).to_list()
Codecov ReportAll modified and coverable lines are covered by tests ✅
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One unit test starts to fail possibly because of how the new numpy handles print output. This PR fixes this and suppresses a few DeprecationWarnings that will become SyntaxErrors in Python 3.12