Skip to content

fix: flaky test in test_data_validator #927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AlexanderFengler merged 2 commits into from
Mar 12, 2026
Merged

fix: flaky test in test_data_validator #927

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0268fb2
fix: flaky test in test_data_validator due to valid choice in random …
krishnbera Mar 10, 2026
ce5c31f
fix: make data validator test deterministic and robust
krishnbera Mar 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions tests/test_data_validator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import random
from typing import Callable

import pytest
Expand Down Expand Up @@ -140,12 +139,12 @@ def test_post_check_data_sanity_valid(base_data):
n_choices=3,
)

invalid_response = random.choice(range(2, 100))
dv_instance_no_missing.data.iloc[0, 1] = invalid_response
invalid_response = max(dv_instance_no_missing.choices) + 1
dv_instance_no_missing.data.loc[0, "response"] = invalid_response
with pytest.raises(ValueError, match=f"Invalid responses found in your dataset: "):
dv_instance_no_missing._post_check_data_sanity()

dv_instance_no_missing.data.iloc[0, 1] = 1 # Reset to valid response
dv_instance_no_missing.data.loc[0, "response"] = 1 # Reset to valid response
with pytest.warns(
UserWarning,
match=(r"missing from your dataset"),
Expand Down