print logs of ephemeral instance after executing preview-cmd#38
Merged
Conversation
|
The ephemeral instance for the application preview has been shut down |
lukqw
force-pushed
the
print-eph-inst-logs
branch
from
ff9eaad to
2899362
Compare
lakkeger
approved these changes
Aug 20, 2024
Contributor
lakkeger
left a comment
lakkeger
left a comment
There was a problem hiding this comment.
Nice addition! 👍 💯 🥇
As we've discussed on a different channel this will be a good addition as a separate sub-action to be usable in other actions or on it's own modularly. -> TBD
Additionally this log fetching should be done at least on failures but could be beneficial every time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
With @remotesynth and @HarshCasper working on the blog post for ephemeral instances and application previews, they have identified the need for getting logs of LocalStack, in case the deployment of their application (= preview-cmd) failed.
Debugging issues with a deployment on LocalStack without logs is basically impossible.
Solution
This PR invokes the new endpoint to fetch logs of ephemeral instances after the preview-cmd is finished, and prints them.