Conversation
…ef' that caused problems for branch-names containing '/'
|
FYI: I'm breaking down the cleanup initiative started in #56 into smaller pieces. |
alexrashed
left a comment
There was a problem hiding this comment.
Awesome! Thanks so much for stabilizing the pipeline, hardening it, and investigating on the ephemeral instance issues! Breaking things up to have small individual PRs is also a great idea given that there might be more to do here to fully clean everything up! 💯 🦸🏽 🧹
| env: | ||
| LOCALSTACK_API_KEY: ${{ secrets.LOCALSTACK_API_KEY }} | ||
| GH_ACTION_VERSION: ${{ github.event_name == 'pull_request' && github.head_ref || github.ref_name }} | ||
| LOCALSTACK_AUTH_TOKEN: ${{ secrets.LOCALSTACK_API_KEY }} |
There was a problem hiding this comment.
nit / out of scope: Since we are at it we could also update the secrets names. I created a secret called LOCALSTACK_AUTH_TOKEN which we could use here directly. If refers to the same CI auth token (i.e. it has the same content than LOCALSTACK_API_KEY).
There was a problem hiding this comment.
nice, thanks 😄
i will update the secret in a follow-up PR, already prepared a commit that removes the usage of LOCALSTACK_API_KEY envs
This PR fixes the basic localstack setup functionalities by the
setup-localstackaction.fix issue with referencing the
GH_ACTION_VERSIONusinggithub.head_refthat caused problems for branch-names containing/clean up + fix of the CI tests in
.github/workflows/ci.yml:LOCALSTACK_API_KEYtemporarly deactivate the CI tests in
.github/workflows/ephemeral.yml