Fix pairwise_judge to use A/B instead of col_A/col_B. col_A/col_B use 2 tokens, so cascade fails#248
Merged
Fix pairwise_judge to use A/B instead of col_A/col_B. col_A/col_B use 2 tokens, so cascade fails#248
Conversation
Co-authored-by: liana313 <lianapat@stanford.edu> Made-with: Cursor
liana313
reviewed
Apr 12, 2026
Collaborator
liana313
left a comment
There was a problem hiding this comment.
Let's also update CI tests to include the pairwise judge and test for edge cases on this
liana313
reviewed
Apr 13, 2026
| assert list(df["_judge_1"].values) == ["A", "B"] | ||
|
|
||
|
|
||
| @pytest.mark.parametrize("model", get_enabled("gpt-4o-mini")) |
Collaborator
There was a problem hiding this comment.
This is a start, but we need more than one CI test for cascade testing. We should cover edge cases (e.g., when there's an existing col A and col B)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Essential Elements of an Effective PR Description Checklist
README.mdandexamplesfor new features.PLEASE FILL IN THE PR DESCRIPTION HERE ENSURING ALL CHECKLIST ITEMS ABOVE HAVE BEEN CONSIDERED.
Purpose
Test Plan
Test Results
(Optional) Documentation Update
Type of Change
Checklist
BEFORE SUBMITTING, PLEASE READ https://github.com/lotus-data/lotus/blob/main/CONTRIBUTING.md
anything written below this line will be removed by GitHub Actions