Migrate Docker CI to docker/github-builder#17124
Open
AFCMS wants to merge 4 commits into
Open
Conversation
sfan5
added
@ Build
This comment was marked as outdated.
This comment was marked as outdated.
Contributor
Author
|
It fails on |
Contributor
Author
|
The actions uses buildkit Git source, and apparently it doesn't copy This doesn't work for the same reason: docker build https://github.com/luanti-org/luanti.git |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following #17090, migrate Docker workflow to
docker/github-builderReduces the complexity of the Docker workflow by using the official Docker reusable workflow which is now the recommended way of building images on GitHub, with automatic dispatching on available runners.
I waited for a release of the workflow to lowercase the image name properly (the ugly hack we used previously to handle forks is no longer needed):
https://github.com/docker/github-builder/releases/tag/v1.6.0
GPT-5.3-Codex have been used to help with the migration.
To do
This PR is a Ready for Review.
How to test
See workflow runs