Skip to content

Bump all used GitHub Actions#17131

Open
AFCMS wants to merge 2 commits into
luanti-org:masterfrom
AFCMS:update_github_actions
Open

Bump all used GitHub Actions#17131
AFCMS wants to merge 2 commits into
luanti-org:masterfrom
AFCMS:update_github_actions

Conversation

@AFCMS
Copy link
Copy Markdown
Contributor

@AFCMS AFCMS commented Apr 24, 2026

Bump all GitHub Actions used by the project.

It fixes a few NodeJS 20 warnings from actions/upload-artifact.

I used the new archive parameter from v7 to upload files directly without the mandatory ZIP container previously required.

LLM inline auto-completion have been used a few times.

To do

This PR is Ready for Review.

  • See workflow runs

How to test

See workflow runs.

@AFCMS AFCMS force-pushed the update_github_actions branch from bd4296a to d92b60d Compare April 24, 2026 19:51
@wsor4035 wsor4035 added the Maintenance Tasks to keep the codebase and related parts in order, including architectural improvements label Apr 24, 2026
uses: actions/upload-artifact@v7
with:
name: luanti-macos${{matrix.osver}}_${{matrix.arch}}
archive: false
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We want an archive, so why's this disabled? Same question for the windows actions.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a new thing in the upload action where you can upload a file verbatim. Previously if you tried to upload an archive it would become a nested zip archive

@sfan5 sfan5 added this to the 5.17.0 milestone May 8, 2026
@sfan5 sfan5 added the 1 approval rule low-risk PR according to Git guidelines label May 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1 approval rule low-risk PR according to Git guidelines Maintenance Tasks to keep the codebase and related parts in order, including architectural improvements One approval ✅ ◻️

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants