Support for 32-bit index buffers; refactor a bunch#17135
Draft
appgurueu wants to merge 6 commits into
Draft
Conversation
appgurueu
added
Maintenance
appgurueu
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements most of the proper solution for #12731. By "support" I mean implement them properly (not as a dead template variant) and make the code actually use them (e.g. mesh loaders).
Will probably toss the refactoring commits in a separate PR later.
How to test
Use fat models for entities. As it turns out the u16 assumption is ingrained in our mesh collector, so not that easy to lift for mesh nodes (see the commit aptly named "todo").
TODO