Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 20 20
=========================================
Hits 20 20 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
I've been capturing the error, and providing a useful note for users. It sounds like there is a way to prompt for permissions, might be a good option too: https://dev.to/bmorearty/better-deno-security-ask-for-permission-at-runtime-1fnm
I'm not sure. Your approach seemed pretty reasonable to me 👍
No, you should be able to ignore |
bcoe
left a comment
There was a problem hiding this comment.
This is looking good 👍 for yargs, I will need the sync option
I think, I'd be happy to pitch in if you run out of cycles this week.
|
Thanks! I'll add extra sync entry. I figured everything would be async in Deno because of top-level await but obviously that was a bad assumption. I think permissions is all that's left to solve. Catching it makes sense for a Happy to focus on it this week. Would hate to be the blocker for your conversion effort |
|
@lukeed yes, let me know where you land on permissions, this is something I'm trying to learn to navigate too. |
|
Hey, so I asked the Deno Discord and the recommendation is to allow the permission errors to happen. Any required permissions should be listed in the README (or in the functions' jsdoc blocks), and it's ultimately up to the consumer to add the appropriate flags. This is also how you can get method/usage-driven granular permissions. I found feature proposals in the Deno repo about adding manifests/import-map-like files to define the permissions ahead of time, but there's not been any action taken on them yet. Design still WIP |
First pass at a Deno entry.
All
fs.*operations are available underDenonamespace.Only had to import
std:pathmodule.Questions:
Deno.*operations require theallow-readpermission. Is this something I have to flag on my side?/denoto my package.json files? Assume not since publishing works thru git releases only//cc @bcoe
Closes #3