Fix a crash when an application error type has a non-numeric "status" property#178
Merged
lukeed merged 2 commits intolukeed:nextfrom Oct 1, 2021
Merged
Fix a crash when an application error type has a non-numeric "status" property#178lukeed merged 2 commits intolukeed:nextfrom
lukeed merged 2 commits intolukeed:nextfrom
Conversation
fix a crash when an application error type has a non-numeric "status" property See lukeed@f95a5b4
lovasoa
changed the title
lukeed
reviewed
Oct 1, 2021
Owner
|
Thanks for PR. PS It's not heated on my end – just trying to give you feedback as to how & why your reports come across as antagonistic. Appreciate the contribution |
lukeed
added a commit
that referenced
this pull request
Oct 1, 2021
- include non-numeric `err.status` tests - restores typeof check from #178
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello @lukeed !
This is a follow-up on the sveltekit issue and f95a5b4
I hope this helps, and lets the discussions be less heated next time ;)