Open
Conversation
…fig file, well at least the last two can be
Contributor
alerque
requested changes
Sep 29, 2020
Member
alerque
left a comment
alerque
left a comment
There was a problem hiding this comment.
This PR looks like you've collected a bunch of stuff that isn't just to fix issue #301 and is not relevant to be merged to the canonical project.
Would you happen to still be around and in a position to fix your branch or split this up into a branch with the relevant bit(s)? I'm happy to facilitate a fix getting merged, but this isn't ready for that.
|
|
||
| Copyright (C) 2011-2012 Steve Donovan. | ||
|
|
||
| ## Fork of Steve Donovan's LDoc that fixes issue 301 and adds the following tags: |
Member
There was a problem hiding this comment.
Before we consider merging this, you should remove anything that suggests this is a fork. We're merging to the bonefied original here ;-)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is want i did to fix issue 301.
Not sure why lines 155 and 217 are showing up here; I don't remember adding those two blanks lines.