Fix Lua 5.5 compatibility and Penlight deprecation warnings#422
Closed
KritzelKratzel wants to merge 1 commit intolunarmodules:masterfrom
Closed
Fix Lua 5.5 compatibility and Penlight deprecation warnings#422KritzelKratzel wants to merge 1 commit intolunarmodules:masterfrom
KritzelKratzel wants to merge 1 commit intolunarmodules:masterfrom
Conversation
- ldoc/doc.lua: Switched pl.text to pl.stringx to resolve Penlight 1.11+ deprecation warnings. - ldoc/html.lua: Resolved "attempt to assign to const variable" by renaming/shadowing loop iterators (tag, name). - ldoc/html/ldoc_ltp.lua: Updated HTML templates to prevent illegal re-assignment of loop variables (kind, type). - ldoc/markdown.lua: Fixed illegal re-assignment of iterator 'k' in unescape_special_chars function.
Tieske
reviewed
Feb 17, 2026
Member
Tieske
left a comment
Tieske
left a comment
There was a problem hiding this comment.
thx for the PR. Shouldn't we also update the CI workflows? they should be updated to run against the Luarocks actions instead of Leafo's (see Penlight for examples). And most importantly, the doc builder should probably run against Lua 5.5 to ensure it works.
Contributor
Author
|
Sure, but I'd better leave that decision to you. My expertise in this area is unfortunately too limited. |
Merged
Member
|
replaced by #423 Thx @KritzelKratzel 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ldoc/doc.lua: Switchedpl.texttopl.stringxto resolve Penlight 1.11+ deprecation warnings *)ldoc/html.lua: Resolved "attempt to assign to const variable" by renaming/shadowing loop iterators (tag, name).ldoc/html/ldoc_ltp.lua: Updated HTML templates to prevent illegal re-assignment of loop variables (kind, type).ldoc/markdown.lua: Fixed illegal re-assignment of iterator 'k' in unescape_special_chars function.*) Lua warning: [Penlight 1.15.0] the contents of module 'pl.text' has moved into 'pl.stringx' (deprecated after 1.11.0, scheduled for removal in 2.0.0)