Untested files are counted taking into account filters include/exclude#115
Open
a1div0 wants to merge 1 commit intolunarmodules:masterfrom
Open
Untested files are counted taking into account filters include/exclude#115a1div0 wants to merge 1 commit intolunarmodules:masterfrom
a1div0 wants to merge 1 commit intolunarmodules:masterfrom
Conversation
Author
|
Sorry, it turned out to be a big merge |
Author
|
It's strange that the tests dropped, mine don't drop: Please help me figure out what's wrong |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To address the issue described in #114, the following changes have been made:
runnerhas been modified to ensure that it contains the entire list of project files potentially involved in test coverage before data accumulation begins.find_luas, has been added. Other reusable methods have been moved to theutilmodule.includeuntestedfilesflag has been updated. For previous versions, no changes are likely needed, as the calculation of untested files will occur if the flag's value is not set tofalse.reporter.lua.