Finish cleaning up gadgets from proving removal#877
Merged
huitseeker merged 9 commits intolurk-lab:mainfrom Nov 13, 2023
Merged
Finish cleaning up gadgets from proving removal#877huitseeker merged 9 commits intolurk-lab:mainfrom
huitseeker merged 9 commits intolurk-lab:mainfrom
Conversation
- the and function in constraints.rs is superseded by https://github.com/lurk-lab/bellpepper/blob/46a3cc4ee72410bd98e67a5f65f96c80f8947942/crates/bellpepper-core/src/constraint_system.rs#L335-L338
- Updated test cases in `src/circuit/gadgets/case.rs` using `multi_case` function instead of `case`. - Adapted assertions to reflect changes introduced by the new function usage.
huitseeker
force-pushed
the
cleanup_gadgets
branch
from
02dcea6 to
8ac80d2
Compare
arthurpaulino
approved these changes
Nov 10, 2023
Contributor
arthurpaulino
left a comment
arthurpaulino
left a comment
There was a problem hiding this comment.
I'm onboard with the migrations and removals, as I've stated via DM.
Thanks!
gabriel-barrett
approved these changes
Nov 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for removals
enforce_pack: utility function subsumed byimplies_packor_v,or_v_unchecked,and_v,and!,or!: ported in feat: Enhance boolean operations in bellpepper crate lurk-lang/bellpepper#55enforce_less_than_bound,enforce_u64_div_mod: slated for soundness fix, see Fix soundness and optimize divrem #664allocate_unconstrained_bignum,to_u64,to_unsigned_integer_helper,to_u64: use div_rem into_unsigned_integer_helper, hence same as above.extend_named,extend_rec: Lurk alpha syntax specific,allocate_is_negative: ported in feat: Enhance boolean operations in bellpepper crate lurk-lang/bellpepper#55Follows-up on #873 #875
Closes #874