Link against the exact python3 version in the system #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
not the latest version (if multiple versions installed).
not only PythonLibs (PythonInterp is used anyway).
Contributor
|
Will check shortly. This approach sounds great to me though. In previous one-off experiments I had been hard-coding with EXACT to get around this sort of thing (with drone app for example). |
Luxonis-Steven
approved these changes
Jun 1, 2020
Luxonis-Steven
left a comment
Luxonis-Steven
left a comment
There was a problem hiding this comment.
Did the test. Looks great. Thanks!
Luxonis-Brandon
approved these changes
Jun 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With multiple
python3versions installed (side by side, or within Conda environments),CMake's
find_packagealways returned the latest (e.g. even if we specify 3.6, if 3.7 is found, it is used instead).With an older python3 interpreter enabled as default, this was causing a wrong lib to be built, not the one expected by the selected python3 interpreter.
However,
find_packagehas an optionEXACTthat would solve the above issue, but we don't want to hardcode a specific version.We query the version from the python3 interpreter and pass it to
find_package.