Pass more data in board config: board name, revision, RGB FOV #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SzabolcsGergely
approved these changes
Apr 23, 2020
| float rgb_fov_deg = 69.f; | ||
| float left_to_right_distance_m = 0.035f; // meters, not centimeters | ||
| float left_to_rgb_distance_m = 0; | ||
| std::string name; |
Contributor
There was a problem hiding this comment.
I think we should set these by default to : Unknown
Collaborator
Author
There was a problem hiding this comment.
Maybe some checks in the code could be a bit cleaner by using name.empty()?
But when displayed for the user, yes we could print something like this.
Display EEPROM data, center L/R cameras
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.