Remove exclude mail#1691
Conversation
thomas-zahner
force-pushed
the
remove-exclude-mail
branch
from
a20c151 to
04cfccc
Compare
| @@ -1,5 +1,5 @@ | |||
| # Needed SHELL since I'm using zsh | |||
| SHELL := /bin/bash | |||
| SHELL := /usr/bin/env bash | |||
| .map(|value| StatusCode::from_u16(*value)) | ||
| .collect::<Result<HashSet<_>, _>>()?; | ||
|
|
||
| // `exclude_mail` will be removed in 1.0. Until then, we need to support it. |
There was a problem hiding this comment.
Yeah, technically the comment says "removed in 1.0", but I think it's fine to do so earlier. We probably even talked about it at some point. 😆
There was a problem hiding this comment.
True and yeah we did talk about it 😄
mre
left a comment
mre
left a comment
There was a problem hiding this comment.
The change looks good, but it will break a lot of code... 💣 💥
We have to do so at some point, but I wonder if you'd like to go through the list and pick the most prominent examples and we create an issue on their side to notify them about the changes?
|
@mre I've actually hand checked almost all of them and surprisingly only very few projects would be directly affected. Many projects use a fixed version, so it won't break without notice. Bigger projects mostly depend on a fixed version of lychee-action. ( |
|
Thanks!
Yeah, because of https://github.com/lycheeverse/lychee-action/blob/82202e5e9c2f4ef1a55a3d02563e1cb6041e5332/action.yml#L30 |
|
That makes sense 👍 I will merge then |
2 participants
Updated the documentation in lycheeverse/lycheeverse.github.io#93 accordingly.