fix: correct button auxclick type, improve error handling and messages#656
Open
jd-paul wants to merge 3 commits intomProjectsCode:masterfrom
Open
fix: correct button auxclick type, improve error handling and messages#656jd-paul wants to merge 3 commits intomProjectsCode:masterfrom
jd-paul wants to merge 3 commits intomProjectsCode:masterfrom
Conversation
jd-paul
commented
Apr 24, 2026
jd-paul
commented
- Fix onauxclick passing ButtonClickType.LEFT instead of MIDDLE
- Show user-facing notice in ButtonComponent when actions throw
- Replace generic Error with MetaBindInternalError for unknown field types
- Fix validator error messages: typo, swapped args, empty description
- Add tests for all modified behaviour
- Fix onauxclick passing ButtonClickType.LEFT instead of MIDDLE - Show user-facing notice in ButtonComponent when actions throw - Replace generic Error with MetaBindInternalError for unknown field types - Fix validator error messages: typo, swapped args, empty description
Owner
mProjectsCode
left a comment
mProjectsCode
left a comment
There was a problem hiding this comment.
Looks good, but what are those files you added to the gitignore? They don't seem like files created by the tooling that is used in this project.
|
|
||
| dist/ No newline at end of file | ||
| dist/ | ||
| # Geth collective intelligence — session logs and working memory |
Author
There was a problem hiding this comment.
Apologies, I need to remove that. Those are some markdown files I use to understand the plugins
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.