Fix stepgen change #3
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
struct stepgen_t contained space for params, but not all were created. Later assignments and comparisons worked even though the param did not exist, because the original hal_xxx_t existed in the struct. When params were converted to pointers to enable real pin creation these shortcuts caused segfaults addressing null pointers Signed-off-by: Mick <[email protected]>
Author
|
Removed the debris from the commit not in your repo, should be clearer now |
Owner
|
Nice catch! |
Owner
|
Back in machinekit#1344 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
struct stepgen_t contained space for params, but not all were created.
Later assignments and comparisons worked even though the param did
not exist, because the original hal_xxx_t existed in the struct.
When params were converted to pointers to enable real pin creation
these shortcuts caused segfaults addressing null pointers