Skip to content

Conversation

@greenbourne277
Copy link

Downloads all images which were printed as common. This change won´t download images of uncommons/rare versions of pauper legal cards. Only the common versions.

@github-actions github-actions bot added the client label Aug 9, 2025
@johannes-wolf
Copy link
Contributor

This might be not 100% correct as some cards that got downshifted to common, e.g. Gut Shot, Elvish Vanguard, etc. wont be downloaded by checking the rarity.

A Pauper download preset should also fetch all variants from all sets. Do we have legality information for cards available?

@muz
Copy link
Contributor

muz commented Dec 27, 2025

A Pauper download preset should also fetch all variants from all sets. Do we have legality information for cards available?

Looks like it!

I note that the ScryfallImageSource has logic to fetch and use Scryfall's bulk data dumps using the all-cards data set;

    private static final String SCRYFALL_BULK_FILES_DATABASE_SOURCE_API = "https://api.scryfall.com/bulk-data/all-cards"; // 300 MB in zip

The card objects represented within have legalities fields available, which include things being Pauper legal (amongst other formats). We'd effectively need to just filter on .legalities.pauper == "legal" to determine which art items to download, taking into account rarity downshifting and banlists etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants