Skip to content

TDFC cleanup follow up #14111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Jmlundeen wants to merge 7 commits into
base: master
Choose a base branch
from
Open

TDFC cleanup follow up #14111

Jmlundeen wants to merge 7 commits into from
+153 −647

Conversation

@Jmlundeen
Copy link
Contributor

@Jmlundeen Jmlundeen commented Dec 7, 2025 •
edited
Loading

This is some additional cleanup for the transforming double faced card rework.

  • remove secondSideCardClazz used by old transforming cards
  • remove TransformAbility since not needed anymore
  • cleanup TODO items
    • moved VALUE_KEY_ENTER_TRANSFORMED to TransformingDoubleFacedCard
    • removed transform validation in Player.moveCards and kept in ZonesHandler. Doesn't seem necessary to have redundant check.
    • removed old transform card check from Mycosynth Lattice and Painter's Servant
    • removed old transform related code from PermanantCard init
    • remove ignoreTransformEffect flag from SpellTransformedAbility (temporary flag to separate from old transform implementation)
    • remove instanceof DoubleFacedCardHalf check from CardImpl copy constructor; DFC will still use the field, instance check is currently just to differentiate between old Transforming logic

part of #14099

@Jmlundeen Jmlundeen mentioned this pull request Dec 7, 2025
Open
JayDi85
JayDi85 reviewed Dec 7, 2025
View reviewed changes
Mage.Sets/src/mage/cards/g/GrimlockDinobotLeader.java
filter2.add(Predicates.not(SubType.DINOSAUR.getPredicate()));
filter2.add(Predicates.not(SubType.VEHICLE.getPredicate()));
filter2.add(Predicates.or(new AbilityPredicate(TransformAbility.class), TransformedPredicate.instance));
filter2.add(TransformablePredicate.instance);
Copy link
Member

@JayDi85 JayDi85 Dec 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like original card has some typos... must be 1 effect and 1 filter, not 2:

shot_251207_214112

Copy link
Contributor Author

@Jmlundeen Jmlundeen Dec 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah it needs a filter like this, but the types are incompatible since AnotherPredicate uses the ObjectSourcePlayer
image

Copy link
Contributor

@xenohedron xenohedron Dec 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The actual card is silver bordered and the existing implementation is bogus anyway because it isn't something that can be well defined in the rules. So not important for this PR.

xenohedron
xenohedron approved these changes Dec 15, 2025
View reviewed changes
Copy link
Contributor

@xenohedron xenohedron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JayDi85 JayDi85 JayDi85 left review comments

@xenohedron xenohedron xenohedron approved these changes

Assignees

No one assigned

Labels

cards client engine tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Jmlundeen @JayDi85 @xenohedron