Skip to content

Conversation

@muz
Copy link
Contributor

@muz muz commented Dec 26, 2025

A handful of minor changes from trying to build things locally;

  • The Makefile needs to pass in package otherwise the expected JAR files for the Client and Server are not correctly built, and are then unable to be included in the generated ZIP file
  • The Utils/build-and-package.pl script generates and tries to clean up after itself a temp directory. To safeguard the cleanup not working or local dev leaving it around, explicitly ignore it to prevent adding it to the git tree
  • The Makefile uses a deploy directory as a target, in the same vein as the second point, exclude it from git

…cript, and exclude build targets from git index
@github-actions github-actions bot added the dev label Dec 26, 2025
@muz
Copy link
Contributor Author

muz commented Dec 26, 2025

Of course, another option here is to make the Makefile just write to the temp directory like that Perl script does, and then only need to include that in the .gitignore for this workflow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant