changes to compile on linux with gcc v12 + Dockerfile #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: CristiMacovei <[email protected]>
Signed-off-by: CristiMacovei <[email protected]>
CristiMacovei
changed the title
razvand
requested changes
May 2, 2025
Dockerfile
Outdated
Comment on lines
3
to
5
| RUN apt update && apt upgrade -y | ||
|
|
||
| RUN apt install -y git cmake build-essential libz-dev libssl-dev libbz2-dev libpng-dev libusb-dev |
Member
There was a problem hiding this comment.
Suggested change
| RUN apt update && apt upgrade -y | |
| RUN apt install -y git cmake build-essential libz-dev libssl-dev libbz2-dev libpng-dev libusb-dev | |
| RUN set -xe; \ | |
| apt-get -yqq update; \ | |
| apt-get install -y git cmake build-essential libz-dev libssl-dev libbz2-dev libpng-dev libusb-dev \ | |
| ; |
This commit makes docker `COPY` from the local files, instead of pulling the codebase from git. In addition, good-practice changes have been added to the `Dockerfile`, such as replacing `apt` with `apt-get` and adding a newline to the end of the file. Signed-off-by: CristiMacovei <[email protected]>
Signed-off-by: CristiMacovei <[email protected]>
Signed-off-by: CristiMacovei <[email protected]>
razvand
requested changes
Aug 12, 2025
Member
There was a problem hiding this comment.
Update your commit messages to follow the best practices in creating commits and commit descriptions.
That is:
- Use your full name for signing-off and for commit authorship:
Cristian Macovei <[email protected]>. - Start sentences with capital letters, e.g. use
Improveinstead ofimprove. - When you add a new file, do not use the verb
Add. Use the verbIntroduce. - Use capitalized words for names, e.g.
Gitinstead ofgit,GCCinstead ofGCC. - Add a detailed description for commit messages, e.g. the commit
add Docker pipeline(the first line should beIntroduce Docker pipeline- followed by an extended description). Same foradd Dockerfileandchanges to compile on linux with gcc v12(which should beUpdate code to build on Linux with GCC >= 12.
| You can also build your own image locally: | ||
|
|
||
| ```sh | ||
| xpwn $ docker build -t <container_name> . |
Member
There was a problem hiding this comment.
Suggested change
| xpwn $ docker build -t <container_name> . | |
| docker build -t <container_name> . |
| @@ -0,0 +1,27 @@ | |||
| # Docker usage instructions | |||
Member
There was a problem hiding this comment.
Suggested change
| # Docker usage instructions | |
| # Docker Usage Instructions |
|
|
||
| ### Setup | ||
|
|
||
| Container images are available on [the github container registry](https://github.com/orgs/malus-security/packages/container/package/xpwn) (and soon on the gitlab container registry). |
Member
There was a problem hiding this comment.
Suggested change
| Container images are available on [the github container registry](https://github.com/orgs/malus-security/packages/container/package/xpwn) (and soon on the gitlab container registry). | |
| Container images are available on [the GitHub Container Registry](https://github.com/orgs/malus-security/packages/container/package/xpwn) (and soon on the GitLab Container Registry). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made changes to compile the project on linux targets using gcc version 12.2.
a variable named
debugwas defined in two places indfu-util/dfu-util/dfu.h: removed declaration ofdebugvariabledfu-util/sam7dfu.c: added extern declaration ofdebugdfu-util/main.ca variable named
endiannesswas already defined and redefined insideipsw-patch/main.candxpwn/src/xpwn.cppexternmodifier to the declaration