Open
Conversation
|
Hi, any progress on that? I'd be interested in this PR being merged. |
Contributor
|
@stokkie90 @palmobar Apologies for letting this sit for so long. This looks simple enough to merge, thanks! manheim-c7n-tools has 100% unit test coverage. Could you please update this PR with some unit test cases (here) for the URL patterns that you're adding support for? Thanks. |
|
Hi, any updates on this issue? I'm looking forward to this PR being merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should fix #31
Description
Describe what this PR does or the problem that it solves. If the description is long, use one summary sentence first, then dive into the details in another paragraph.
Testing Done
What was done to test this? Paste build link(s), console output, notes, etc.
Important Notes
Optional; instructions to reviewers, plans for how to release this, dependencies in other repos, etc.
Contributor License Agreement
Required for external contributors.
By submitting this work for inclusion in manheim-c7n-tools, I agree to the following terms:
is being made under the same license as the manheim-c7n-tools project (Apache v2).
this pull request grants a perpetual, global, unlimited license for it to be used and distributed
under the terms of manheim-c7n-tools's license.