Check pull requests from the old theme

[natrius]

There are still 11 pull requests open on the old themes, maybe its worth looking into that https://github.com/Vimux/Mainroad/pulls to quickly improve some stuff? If you have done already, it should be mentioned here and then this issue can be closed imo.

[mansoorbarri]

thats a good idea. I have created this branch and will be committing important fixes from the original theme.

[mansoorbarri]

PRs implemented | Update (05.01.2025)

• Replaced outdated .Site.IsMultiLinual Replaced outdated .Site.IsMultiLinual Vimux/Mainroad#384 - Implemented in (29bf196) thanks to @natrius.
• Update Authorbox to use author data Update Authorbox to use author data Vimux/Mainroad#383 - Implemented already in (9f52897).
• feat: update for new Pagination template action feat: update for new Pagination template action Vimux/Mainroad#380 - Implemented in (cfbf261).
• Due to deprecated .Site.Author taxonomy should be used Due to deprecated .Site.Author taxonomy should be used Vimux/Mainroad#379 - Implemented in ((9f52897).
• Replace Twitter with X in social widget Replace Twitter with X in social widget Vimux/Mainroad#362 - Implemented in (f8579e0).

PR I won't be implementing in Roadster

• Made the credits in footer optional(Made the credits in footer optional Vimux/Mainroad#387) - This is PR helps improve lighthouse scores which I am not focusing on right now.
• Bump braces from 3.0.2 to 3.0.3 Vimux/Mainroad#371 & Solving deprecated Vimux/Mainroad#374 - deals with depreciation which is already fixed in one of the commits mentioned above.
• Add i18n supports for Korean Vimux/Mainroad#333 - there were some valid suggestions by the maintainer of the original theme which have not yet fixed.
• Add a minimum value to display tags in widget Vimux/Mainroad#242 - this PR doesn't address the issue properly as mentioned by the original maintainer.
• Append home page title to / title (if on home) Vimux/Mainroad#213 - this PR would lead the title to be mentioned twice. not a good PR.

CC: @natrius

[lrh11099]

Vimux#242 - this PR doesn't address the issue properly as mentioned by the original maintainer.

I think here the best thing is to make it configurable (as a param in config) so that a user can define the maximum number of tags to show (you can define the default part to a certain number). By default, tags should be grouped by the most in use in descending oder.

[mansoorbarri]

should we make it so it uses the pagination.pagerSize value? I think that would be appropriate rather than having a different value for each list section.

Vimux#242 - this PR doesn't address the issue properly as mentioned by the original maintainer.

I think here the best thing is to make it configurable (as a param in config) so that a user can define the maximum number of tags to show (you can define the default part to a certain number). By default, tags should be grouped by the most in use in descending oder.

[lrh11099]

If I read the issue right, this is about the number of tags that appear in the sidebar?

[mansoorbarri]

yes it is. the solution suggested in the original PR is to have another variable in the config (for example: paginateTags) which would be a number. something like pagination.pagerSize.

in my other themes, I have used the pagination.pagerSize to be used to paginate tags.

[lrh11099]

OOh. I would like to see that in action. I didn't know you can paginate tags

[mansoorbarri]

should we close this issue and add "limit tags" in the roadmap?

CC: @stoic-hugo @natrius

[natrius]

Sounds good to me :)

[lrh11099]

Yes. You (and/or we) could check other requested features from mainroad that you could add to the roadmap.