Skip to content

bugfix/fire draw update consistently #1160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stepankuzmin merged 2 commits into from
Mar 14, 2023
Merged

bugfix/fire draw update consistently #1160

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
db7fa29
fix(direct_select): trigger update consistently
gynekolog Feb 14, 2023
ce96883
fix(simple_select): trigger update consistently
gynekolog Feb 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/modes/direct_select.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,10 +183,15 @@ DirectSelect.onMouseMove = function(state, e) {
// On mousemove that is not a drag, stop vertex movement.
const isFeature = isActiveFeature(e);
const onVertex = isVertex(e);
const isMidPoint = isMidpoint(e);
const noCoords = state.selectedCoordPaths.length === 0;
if (isFeature && noCoords) this.updateUIClasses({ mouse: Constants.cursors.MOVE });
else if (onVertex && !noCoords) this.updateUIClasses({ mouse: Constants.cursors.MOVE });
else this.updateUIClasses({ mouse: Constants.cursors.NONE });

const isDraggableItem = onVertex || isFeature || isMidPoint;
if (isDraggableItem && state.dragMoving) this.fireUpdate();

this.stopDragging(state);

// Skip render
Expand Down
5 changes: 4 additions & 1 deletion src/modes/simple_select.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,10 @@ SimpleSelect.onStop = function() {
doubleClickZoom.enable(this);
};

SimpleSelect.onMouseMove = function(state) {
SimpleSelect.onMouseMove = function(state, e) {
const isFeature = CommonSelectors.isFeature(e);
if (isFeature && state.dragMoving) this.fireUpdate();

// On mousemove that is not a drag, stop extended interactions.
// This is useful if you drag off the canvas, release the button,
// then move the mouse back over the canvas --- we don't allow the
Expand Down