Fix the Json serializer issue in the client project#132
Closed
matthewjameslockwood wants to merge 4 commits intomarain-dotnet:masterfrom
matthewjameslockwood:feature/client-fix
Closed
Fix the Json serializer issue in the client project#132matthewjameslockwood wants to merge 4 commits intomarain-dotnet:masterfrom matthewjameslockwood:feature/client-fix
matthewjameslockwood wants to merge 4 commits intomarain-dotnet:masterfrom
matthewjameslockwood:feature/client-fix
Conversation
|
|
jongeorge1
previously approved these changes
Feb 9, 2021
idg10
reviewed
Feb 9, 2021
.../UserNotifications/Client/Management/Resources/CommunicationTemplates/SmsTemplateResource.cs
Show resolved
Hide resolved
idg10
reviewed
Feb 9, 2021
...rain/UserNotifications/Client/Management/Resources/CommunicationTemplates/WebPushTemplate.cs
Outdated
Show resolved
Hide resolved
idg10
reviewed
Feb 9, 2021
...rNotifications/Client/Management/Resources/CommunicationTemplates/WebPushTemplateResource.cs
Show resolved
Hide resolved
idg10
approved these changes
Feb 9, 2021
Contributor
|
Merged via #133 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We found an issue with the Client yesterday afternoon after v0.3.0 was created.
The SetNotificationTemplate method in the Client was not serializing the WebPushTemplate object correctly. We've assumed it has something to do with it inheriting from ICommunicationTemplate.
This PR includes the following changes:
JsonSerializer.Serializein theBuildRequest<T>method in theClientBaseclass