fix: make promises call scope.end() in measureFn#1
Merged
maraisr merged 3 commits intomaraisr:mainfrom Aug 31, 2022
Merged
Conversation
Owner
|
hi @andresusanto 👋🏻 thanks for this! Wonder if we should write a test for this, probably should have caught it sooner. |
Contributor
Author
sounds good @maraisr, I will add some additional tests to catch this behaviour |
Owner
|
if this is blocking ya'll, ill merge and release, and loop back to tests after? What say you? |
Contributor
Author
I've added the tests @maraisr, should be able to cover the edge case, cheers 🙌 |
Contributor
Author
|
thanks for merging and releasing @maraisr !! 🙌 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Hi @maraisr, I've found a little issue where
.end()is not being called bymeasureFnwhen we're measuring promises. It makes spans missing the end time and hence duration.