fix: fall back to default font when no -f flag is given#3
Open
kdedev wants to merge 1 commit intomarchaesen:mainfrom
Open
fix: fall back to default font when no -f flag is given#3kdedev wants to merge 1 commit intomarchaesen:mainfrom
kdedev wants to merge 1 commit intomarchaesen:mainfrom
Conversation
When st-wl is launched without the -f flag, opt_font is NULL. The line 'usedfont = opt_font' passes NULL to wlloadfonts(), which skips FcNameParse entirely and calls wlloadfont() with a NULL pattern. This causes 'can't open font (null)' and the terminal fails to start. Fix: fall back to the static font variable defined at the top of wl.c when opt_font is not set.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When st-wl is launched without the
-fflag,opt_fontis NULL.The line
usedfont = opt_fontpasses NULL towlloadfonts(), which skipsFcNameParseentirely and callswlloadfont()with a NULL pattern.This causes
can't open font (null)and the terminal fails to start.Fix: fall back to the static
fontvariable defined at the top ofwl.cwhen
opt_fontis not set.