Finding #7: Duplication of common utilities (log_info/log_error/api_request/help)
Evidence:
Duplicate definitions across dozens of scripts (e.g., log_info() appears 28x; main() 249x).
Risk:
Maintenance burden; inconsistent behavior across scripts; harder to fix bugs globally.
Recommended Action:
- Consolidate into
templates/standard-functions.sh or .agents/scripts/shared-constants.sh and source them
- Add a lightweight module policy: new helpers must go through the shared module; per-script copies deprecated
Source: #2386
Finding #7: Duplication of common utilities (log_info/log_error/api_request/help)
Evidence:
Duplicate definitions across dozens of scripts (e.g.,
log_info()appears 28x;main()249x).Risk:
Maintenance burden; inconsistent behavior across scripts; harder to fix bugs globally.
Recommended Action:
templates/standard-functions.shor.agents/scripts/shared-constants.shand source themSource: #2386