In @.agents/scripts/supervisor-helper.sh:
- Around line 10218-10239: The script writes task_creation_cooldown_file using
SUPERVISOR_STATE_DIR without guarding against an unset or missing directory
which can cause failures under set -u/-e; change the assignment that builds
task_creation_cooldown_file to use a safe default for SUPERVISOR_STATE_DIR (e.g.
${SUPERVISOR_STATE_DIR:-/var/lib/supervisor}) and ensure the directory exists
before any write by creating it if missing (mkdir -p) prior to using date >
"$task_creation_cooldown_file"; apply these changes around the
task_creator_script / task_creation_cooldown_file logic to protect writes and
avoid pulse aborts.
- Around line 10236-10299: The cooldown timestamp for task creation is being
written to task_creation_cooldown_file before prerequisites and execution
complete, which can throttle retries if TODO.md is missing or the task creator
fails; move the write of date +%s to after confirming TODO.md exists and after
tasks_added is determined (i.e., after verifying task_repo/TODO.md and running
task_creator_script and parsing cr_tasks) and only write the cooldown when the
operation has actually succeeded or at least when prerequisites are satisfied
(use the same symbols: should_run_task_creation, task_creation_cooldown_file,
task_repo/TODO.md, task_creator_script, cr_tasks, and tasks_added to locate
where to relocate the timestamp).
Unactioned Review Feedback
Source PR: #1170
File:
generalReviewers: coderabbit
Findings: 1
Max severity: medium
MEDIUM: coderabbit (coderabbitai[bot])
Actionable comments posted: 2
🤖 Fix all issues with AI agents
View comment
Auto-generated by
quality-feedback-helper.sh scan-merged. Review each finding and either fix the code or dismiss with a reason.