Skip to content

fix: replace associative array with string lookup in cmd_close (t283)#1086

Merged
marcusquinn merged 1 commit intomainfrom
bugfix/t283-no-assoc-array
Feb 11, 2026
Merged

fix: replace associative array with string lookup in cmd_close (t283)#1086
marcusquinn merged 1 commit intomainfrom
bugfix/t283-no-assoc-array

Conversation

@marcusquinn
Copy link
Copy Markdown
Owner

Summary

  • declare -A + ${#arr[@]} under set -u triggers unbound variable on empty arrays in bash 4/5 (Ubuntu GHA runners)
  • Third fix for t283 — replaced associative array with newline-delimited string lookup using grep
  • Portable across bash 3.2+ (macOS) and bash 4/5 (Linux), no set -u issues

declare -A + ${#arr[@]} under set -u triggers 'unbound variable' on
empty arrays in bash 4/5. Replace with newline-delimited string lookup
using grep — portable, no set -u issues, same O(n) performance.
@gemini-code-assist
Copy link
Copy Markdown

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@marcusquinn marcusquinn merged commit 6ed2be1 into main Feb 11, 2026
5 checks passed
@marcusquinn marcusquinn deleted the bugfix/t283-no-assoc-array branch February 11, 2026 04:29
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Feb 11, 2026

Warning

Rate limit exceeded

@marcusquinn has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 21 minutes and 24 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch bugfix/t283-no-assoc-array

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown
Contributor

🔍 Code Quality Report

�[0;35m[MONITOR]�[0m Code Review Monitoring Report

�[0;34m[INFO]�[0m Latest Quality Status:
SonarCloud: 0 bugs, 0 vulnerabilities, 47 code smells

�[0;34m[INFO]�[0m Recent monitoring activity:
Wed Feb 11 04:29:29 UTC 2026: Code review monitoring started
Wed Feb 11 04:29:29 UTC 2026: SonarCloud - Bugs: 0, Vulnerabilities: 0, Code Smells: 47

📈 Current Quality Metrics

  • BUGS: 0
  • CODE SMELLS: 47
  • VULNERABILITIES: 0

Generated on: Wed Feb 11 04:29:32 UTC 2026


Generated by AI DevOps Framework Code Review Monitoring

@sonarqubecloud
Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code-reviews-actioned All review feedback has been actioned

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant