Skip to content

t1899: fix placeholder issue bodies, add signature footers, gate dispatch on body quality#17522

Merged
marcusquinn merged 1 commit intomainfrom
bugfix/t1899-issue-body-signature
Apr 6, 2026
Merged

t1899: fix placeholder issue bodies, add signature footers, gate dispatch on body quality#17522
marcusquinn merged 1 commit intomainfrom
bugfix/t1899-issue-body-signature

Conversation

@marcusquinn
Copy link
Copy Markdown
Owner

Summary

  • claim-task-id.sh: Replaced opaque placeholder body (Task created via claim-task-id.sh) with a structured body composed from the task title, plus a warning when --description is omitted
  • claim-task-id.sh + issue-sync-lib.sh: Both now append gh-signature-helper.sh footer to every created issue (build.txt rule docs(cloudron): add SSH diagnostics, forum reference, and database troubleshooting #8 compliance)
  • pulse-wrapper.sh: Deterministic fill floor now skips issues with placeholder/empty bodies, preventing wasted worker dispatch

Root cause: claim-task-id.sh delegates to issue-sync-helper.sh push (which composes rich bodies from TODO.md), but this structurally fails for new tasks because the TODO.md entry doesn't exist yet when the ID is first claimed. The fallback path used a hardcoded string with no signature. Three workers were dispatched to #17511 with this undescribed body.

Closes #17520


aidevops.sh v3.6.113 plugin for OpenCode v1.3.15 with claude-opus-4-6 spent 11m and 10,516 tokens on this with the user in an interactive session. Overall, 7m since this issue was created.

…atch on body quality

claim-task-id.sh fallback path created issues with 'Task created via
claim-task-id.sh' as body when no --description was passed. Neither
claim-task-id.sh nor issue-sync-lib.sh appended provenance signature
footers (build.txt rule #8). The pulse dispatched workers to these
undescribed issues, wasting sessions.

Fixes:
- claim-task-id.sh: compose structured body from title when no
  --description; warn callers about the gap
- claim-task-id.sh + issue-sync-lib.sh: append gh-signature-helper.sh
  footer to all created issues
- pulse-wrapper.sh: skip issues with placeholder/empty bodies in
  deterministic fill floor dispatch

Closes #17520
@gemini-code-assist
Copy link
Copy Markdown

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 6, 2026

Important

Review skipped

Auto reviews are limited based on label configuration.

🚫 Review skipped — only excluded labels are configured. (1)
  • no-review

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: dee560b6-486a-410d-9f90-7367fba91e59

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch bugfix/t1899-issue-body-signature

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added the bug Something isn't working label Apr 6, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 6, 2026

🔍 Code Quality Report

�[0;35m[MONITOR]�[0m Code Review Monitoring Report

SonarCloud: 0 bugs, 0 vulnerabilities, 1 code smells

Mon Apr 6 01:29:00 UTC 2026: Code review monitoring started
Mon Apr 6 01:29:00 UTC 2026: SonarCloud - Bugs: 0, Vulnerabilities: 0, Code Smells: 1

📈 Current Quality Metrics

  • BUGS: 0
  • CODE SMELLS: 1
  • VULNERABILITIES: 0

Generated on: Mon Apr 6 01:29:03 UTC 2026


Generated by AI DevOps Framework Code Review Monitoring

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Apr 6, 2026

@codacy-production
Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

TIP This summary will be updated as you push new changes. Give us feedback

@marcusquinn marcusquinn merged commit 3d5f46b into main Apr 6, 2026
29 of 31 checks passed
@marcusquinn
Copy link
Copy Markdown
Owner Author

Summary

  • claim-task-id.sh: Replaced opaque placeholder body (Task created via claim-task-id.sh) with a structured body composed from the task title, plus a warning when --description is omitted
  • claim-task-id.sh + issue-sync-lib.sh: Both now append gh-signature-helper.sh footer to every created issue (build.txt rule docs(cloudron): add SSH diagnostics, forum reference, and database troubleshooting #8 compliance)
  • pulse-wrapper.sh: Deterministic fill floor now skips issues with placeholder/empty bodies, preventing wasted worker dispatch
    Root cause: claim-task-id.sh delegates to issue-sync-helper.sh push (which composes rich bodies from TODO.md), but this structurally fails for new tasks because the TODO.md entry doesn't exist yet when the ID is first claimed. The fallback path used a hardcoded string with no signature. Three workers were dispatched to t1898: PostToolUse hook on mcp_task to auto-record child subagent tokens via record-child #17511 with this undescribed body.

aidevops.sh v3.6.113 plugin for OpenCode v1.3.15 with claude-opus-4-6 spent 11m and 10,516 tokens on this with the user in an interactive session. Overall, 7m since this issue was created.


Merged via PR #17522 to main.
Merged by deterministic merge pass (pulse-wrapper.sh).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

t1899: Fix placeholder issue bodies and missing signature footers in claim-task-id.sh and issue-sync-helper.sh

1 participant