GH#17808: add CI nesting threshold proximity guard to pulse complexity scan

[marcusquinn]

Summary

Adds a proactive regression guard to the pulse complexity scan that warns before the CI nesting depth threshold is exceeded.

Root cause (GH#17808)

The Complexity Analysis CI check failed 6 times in a short window because new scripts pushed the global nesting depth violation count over the threshold (278→279). Each time, the fix was reactive: bump the threshold after PRs started failing. The systemic fix (threshold bump to 279) was already applied to main in commit d531c1d6e.

What this PR adds

_check_ci_nesting_threshold_proximity() in pulse-wrapper.sh:

• Counts nesting depth violations using the same awk logic as the CI check (global counter, no function-boundary resets)
• Reads the threshold from .agents/configs/complexity-thresholds.conf
• When violations are within 5 of the threshold, creates a warning issue with remediation steps
• Deduplicates: skips if an open warning issue already exists
• Called from run_weekly_complexity_scan independently of tree-change detection (runs even when no files changed)

.agents/configs/complexity-thresholds.conf: Documents the proximity guard so maintainers know to bump the threshold with a rationale comment.

Files changed

• EDIT: .agents/scripts/pulse-wrapper.sh — new _check_ci_nesting_threshold_proximity() function + call site in run_weekly_complexity_scan
• EDIT: .agents/configs/complexity-thresholds.conf — documents the proximity guard

Runtime testing

• Risk: Low (new function is best-effort, non-fatal, wrapped in || true)
• Testing: ShellCheck clean on extracted function; logic verified against CI awk pattern

Runtime Testing

• Risk: Low
• Testing: ShellCheck on new function (zero violations), logic review against CI awk pattern

Resolves #17808

---

aidevops.sh v3.6.170 plugin for Claude Code spent 10m on this as a headless worker.

[gemini-code-assist]

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

[coderabbitai]

Important

Review skipped

Auto reviews are limited based on label configuration.

🚫 Review skipped — only excluded labels are configured. (1)

• no-review

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 91278fc4-8302-4b51-99ea-8b39e00ee9d4

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch bugfix/gh17808-complexity-ci-regression

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[marcusquinn]

Completion Summary

• What: Added _check_ci_nesting_threshold_proximity() to pulse-wrapper.sh — warns when nesting depth violations are within 5 of the CI threshold, preventing reactive threshold bumps
• Issue: Systemic CI failure: Complexity Analysis (6 events) #17808
• Files changed: .agents/scripts/pulse-wrapper.sh, .agents/configs/complexity-thresholds.conf
• Testing: ShellCheck clean on new function; CI reruns triggered for affected open PRs (17800, 17805)
• Key decisions: Buffer of 5 chosen to give 1-2 PRs worth of headroom; guard runs independently of tree-change detection so it fires even when no files changed

[github-actions]

🔍 Code Quality Report

�[0;35m[MONITOR]�[0m Code Review Monitoring Report

SonarCloud: 0 bugs, 0 vulnerabilities, 647 code smells

Wed Apr 8 04:38:32 UTC 2026: Code review monitoring started
Wed Apr 8 04:38:32 UTC 2026: SonarCloud - Bugs: 0, Vulnerabilities: 0, Code Smells: 647

📈 Current Quality Metrics

• BUGS: 0
• CODE SMELLS: 647
• VULNERABILITIES: 0

Generated on: Wed Apr 8 04:38:35 UTC 2026

---

Generated by AI DevOps Framework Code Review Monitoring

[codacy-production]

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

_{TIP This summary will be updated as you push new changes. Give us feedback}

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[marcusquinn]

Completion Summary

• What: Added _check_ci_nesting_threshold_proximity() to pulse-wrapper.sh — warns when nesting depth violations are within 5 of the CI threshold, preventing reactive threshold bumps
• Issue: Systemic CI failure: Complexity Analysis (6 events) #17808
• Files changed: .agents/scripts/pulse-wrapper.sh, .agents/configs/complexity-thresholds.conf
• Testing: ShellCheck clean on new function; CI reruns triggered for affected open PRs (17800, 17805)
• Key decisions: Buffer of 5 chosen to give 1-2 PRs worth of headroom; guard runs independently of tree-change detection so it fires even when no files changed

---

Merged via PR #17822 to main.
Merged by deterministic merge pass (pulse-wrapper.sh).

aidevops.sh v3.6.171 spent 9m on this as a headless bash routine.