chore(t1990): add TODO completion marker for merged PR #18414#18417
chore(t1990): add TODO completion marker for merged PR #18414#18417marcusquinn merged 1 commit intomainfrom
Conversation
The t1990 brief and code change were committed via the PR worktree, but the TODO entry was never added. This is the compliance commit under the new rule (t1990 itself) — adding TODO.md from a chore worktree rather than directly on canonical main. Marks t1990 complete with pr:#18414.
|
Important Review skippedAuto reviews are limited based on label configuration. 🚫 Review skipped — only excluded labels are configured. (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🔍 Code Quality Report�[0;35m[MONITOR]�[0m Code Review Monitoring Report SonarCloud: 0 bugs, 0 vulnerabilities, 224 code smells Sun Apr 12 20:57:50 UTC 2026: Code review monitoring started 📈 Current Quality Metrics
Generated on: Sun Apr 12 20:57:54 UTC 2026 Generated by AI DevOps Framework Code Review Monitoring |
Up to standards ✅🟢 Issues
|
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the TODO.md file to mark task t1990 as completed, which involves changes to how canonical branches are handled in interactive sessions. Feedback was provided to move this completed task entry from the 'Ready' section to the 'Done' section to ensure it is not overwritten by automated task management scripts.
|
|
||
| - [ ] t1985 test: extend stub-harness pattern from t1969 to issue-sync-lib.sh — t1983's P0 bug would have been caught on day one by a stub-based test covering add_gh_ref_to_todo. Same pattern as test-privacy-guard.sh (t1969), applied to issue-sync-lib.sh with ~10 tests covering 6 functions (add_gh_ref_to_todo, fix_gh_ref_in_todo, add_pr_ref_to_todo, strip_code_fences, _escape_ere, parse_task_line). Include explicit regression test for t1983. #test #auto-dispatch #interactive ~2h tier:standard ref:GH#18404 logged:2026-04-12 blocked-by:t1983 -> [todo/tasks/t1985-brief.md] | ||
|
|
||
| - [x] t1990 feat(pre-edit-check): canonical stays on main in interactive sessions — no main-branch planning exception for interactive. is_main_allowlisted_path() short-circuits FALSE when no headless env var is set (FULL_LOOP_HEADLESS / AIDEVOPS_HEADLESS / OPENCODE_HEADLESS / GITHUB_ACTIONS). Every interactive edit — TODO.md, todo/**, README.md, code — goes through a linked worktree. Headless sessions keep the allowlist for routine bookkeeping. Docs updated in AGENTS.md + build.txt. #enhancement #interactive ~45m tier:standard logged:2026-04-12 -> [todo/tasks/t1990-brief.md] pr:#18414 completed:2026-04-12 |
There was a problem hiding this comment.
This completed task is being added to the 'Ready' section. Since this section is auto-generated by the /ready command or beads-sync-helper.sh, manual additions may be overwritten. Please follow these operational guidelines:
- Move this entry to the 'Done' section (starting at line 2080) to ensure it is preserved.
- If it must stay in 'Ready' for a specific reason, group it with other completed tasks at the top of the section for consistency.
References
- For important operational details like task management and section usage, format instructions as bullet points for clarity and readability.
The post-merge-review-scanner used to emit issue bodies with bot comments truncated to 200 chars mid-sentence and no file:line refs, forcing workers to re-fetch the PR review API just to understand the task. Two Sonnet workers timed out on issue #18538 doing exactly that, triggering the t2008 no-progress fail-safe. Rewrite the body builder so each issue includes: - A 'Files to modify' bullet list with deduped `path:line` refs - A 'Worker Guidance' section with explicit implementation steps - Full inline comments (capped at 2000 chars each, blockquoted) - Full PR review summaries - Direct links to the inline comments on GitHub Also move the completed t1990 entry from the Ready section to Done in TODO.md, addressing the original Gemini comment on PR #18417 that issue #18538 was tracking.
…18607) The post-merge-review-scanner used to emit issue bodies with bot comments truncated to 200 chars mid-sentence and no file:line refs, forcing workers to re-fetch the PR review API just to understand the task. Two Sonnet workers timed out on issue #18538 doing exactly that, triggering the t2008 no-progress fail-safe. Rewrite the body builder so each issue includes: - A 'Files to modify' bullet list with deduped `path:line` refs - A 'Worker Guidance' section with explicit implementation steps - Full inline comments (capped at 2000 chars each, blockquoted) - Full PR review summaries - Direct links to the inline comments on GitHub Also move the completed t1990 entry from the Ready section to Done in TODO.md, addressing the original Gemini comment on PR #18417 that issue #18538 was tracking.
…ession t2059 (GH#18745) and t2060 (GH#18746) claimed via claim-task-id.sh prior to this commit; guard bypassed because local counter cache lags the just-completed atomic claims (counter is at 2061 on origin). t2059: promote worker-is-triager to a universal worker rule in prompts/build.txt and AGENTS.md (tier:simple, ~20m, copy-paste). t2060: flip task-complete-helper.sh to move completed entries from ## Ready to ## Done instead of in-place [x] marking, plus one-time retroactive cleanup of the ~20 polluted entries (tier:standard, ~1.75h). Also fix the misleading <!-- Auto-generated --> comment under TODO.md ## Ready that was the source of Gemini's false premise on PR #18417. For #18745 For #18746
1 participant
Summary
Adds the TODO.md completion marker for the just-merged t1990 PR #18414. The original t1990 PR merged the code change and brief but didn't include a TODO.md entry.
Why a separate chore PR
This is the first edit made under the new rule that t1990 itself enforces: no direct TODO.md commits to main in interactive sessions. Under the pre-t1990 regime I would have committed this single-line addition directly to main. Under the new regime, it goes through a worktree + PR.
The commit serves as both the audit trail for t1990's completion AND a live demonstration that the rule is being followed by the session that tightened it.
$SIG